Webkitdebugger for new node debugger protocol#1483
Webkitdebugger for new node debugger protocol#1483paulvanbrenk merged 9 commits intomicrosoft:masterfrom
Conversation
This needs matching changes in the webkit debugger component.
billti
left a comment
billti
left a comment
There was a problem hiding this comment.
Left a couple comments. Have you tested this built and applied to VS 2015 Update 3?
| internal HierarchyNode FindNodeByFullPath(string name) { | ||
| Site.GetUIThread().MustBeCalledFromUIThread(); | ||
|
|
||
| if (name.StartsWith("mdha:", StringComparison.OrdinalIgnoreCase)) { |
There was a problem hiding this comment.
What's special about this prefix? Can you add a comment?
There was a problem hiding this comment.
found a better solution.
| _attached = true; | ||
| } | ||
|
|
||
| public NodeDebugger(string exe, string script, string dir, string env, string interpreterOptions, NodeDebugOptions debugOptions, ushort? debuggerPort = null, bool createNodeWindow = true) |
There was a problem hiding this comment.
This line is nearly 200 chars wide now. Please leave it wrapped as it originally was so it is readable.
| _webkitDebugger.Checked = page.UseWebKitDebugger; | ||
|
|
||
| #if !DEV15 | ||
| _webkitDebugger.Enabled = false; |
There was a problem hiding this comment.
So does this option appear at all on < Dev15? Or does it appear and is disabled?
There was a problem hiding this comment.
it appears but is disabled. I can hide it, but then there is a weird gap between the normal options and the survey options.
| <data name="_surveyNewsCheckCombo.Items" xml:space="preserve"> | ||
| <value>Never</value> | ||
| <data name="_webkitDebugger.Text" xml:space="preserve"> | ||
| <value>Use the new NodeJs debugger protocol (for NodeJs v7.5+)</value> |
There was a problem hiding this comment.
This actually works from Node.js v6.8.0 onwards on Windows.
| return IntPtr.Zero; | ||
| } | ||
|
|
||
| var guiSize = Marshal.SizeOf(typeof(Guid)); |
3 participants
Node will stop supporting the old debugger protocol.
This PR adds uses the webkit debugger, which already exists in VS, which supports the new V8 debugger protocol, which is expected to be the only supported in Node V8.
Note: this needs localization so the new option work in other languages than 'en', and needs some bugfixes in the WebKit debugger.